Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [RUMF-783] collect view.first_input_time #676

Merged
merged 4 commits into from
Jan 8, 2021
Merged

✨ [RUMF-783] collect view.first_input_time #676

merged 4 commits into from
Jan 8, 2021

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Jan 8, 2021

Motivation

Following collection of web-vitals metrics, add first input time to show users when the first Interaction occurs.

Changes

  • update model
  • collect first input time when collecting first input delay

Testing

automated + sandbox tests

I have gone over the contributing documentation.

@bcaudan bcaudan requested a review from a team as a code owner January 8, 2021 13:29
BenoitZugmeyer
BenoitZugmeyer approved these changes Jan 8, 2021
View reviewed changes
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straightforward, 👍

@bcaudan bcaudan merged commit 75f59f9 into master Jan 8, 2021
@bcaudan bcaudan deleted the bcaudan/first-input-time branch January 8, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenoitZugmeyer BenoitZugmeyer BenoitZugmeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcaudan @BenoitZugmeyer