[RUMF-819] postpone start recording #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenoitZugmeyer
force-pushed
the
benoit/postpone-recording
branch
from
bee9dd5 to
43cab66
Compare
kcaffrey
pushed a commit
to WonderInventions/browser-sdk
that referenced
this pull request
Jan 29, 2021
* [RUMF-819] split rum recorder API creation and global definition * ⚗✨ [RUMF-819] postpone recording
kcaffrey
added a commit
to WonderInventions/browser-sdk
that referenced
this pull request
Jan 29, 2021
This reverts commit a2a8fc9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For dogfooding, we want to be able to conditionally start the recording according to a frontend feature flag. Currently, calling
DD_RUM.init()systematically starts the recording.Changes
This PR adds an experimental flag to postpone the recording, and (if enabled) exposes a
startSessionRecordmethod. This is behind a flag because we are not sure if we want to stabilize this API for now.Testing
Unit tests, manual testing
I have gone over the contributing documentation.