[REPLAY-164] track Focus records #707
Conversation
This makes things less confusing by removing `Event` and `EventTypes` types altogether, replacing them with proper `Record` and `RecordTypes`. This will help adding new record types.
We'll want to emit records without adding more code to RRWeb. Thus, move the wraping utility to our code.
BenoitZugmeyer
changed the title
We are sending an event when the focus is lost too (blur). Did you experience this yourself? |
| incrementalSnapshotCount += 1 | ||
| const exceedCount = checkoutEveryNth && incrementalSnapshotCount >= checkoutEveryNth | ||
| const exceedTime = checkoutEveryNms && e.timestamp - lastFullSnapshotEvent.timestamp > checkoutEveryNms | ||
| const exceedTime = checkoutEveryNms && Date.now() - lastFullSnapshotRecordTimestamp > checkoutEveryNms |
There was a problem hiding this comment.
Why did you changed from e.timestampto Date.now()?
There was a problem hiding this comment.
Because rrweb/record uses RawRecords instead of Records now, so records don't have the timestamp property anymore. They are "wraped" later in the recorder code. See the whole commit for context 995f863
mb, I misunderstood. all good :) |
Motivation
Add focus information to always show the currently focused view during replay
Changes
Testing
Unit tests, manual tests
I have gone over the contributing documentation.