-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Allow logs collection on file:// URL #709
Conversation
The motivation for this change is to allow logging from an Electron app, where it is standard to bundle the JS with webpack and serve the bundle from a file locally.
Thanks for your contribution @kcaffrey, it has been released with 2.5.0! |
I'm also using electron, and this change allows it to run, but I'm still getting a I tried to enable Any suggestions for this specific usecase if anyone else has run into would be appreciated, and I'll update this comment if I figure it out. |
Hello @johnpyp, Are you using only Logs SDK on 2.5.0 version? Thanks! |
Motivation
The motivation for this change is to allow logging from an Electron app, where it is standard to bundle the JS with webpack and serve the bundle from a file locally.
Changes
This change remove the local file check to allow logs SDK initialization when the page is served from file:// protocol.
Testing
There are no automated tests for this change, as I did not see any pre-existing tests for the local file initialization check, but I tested by building the bundle and pointing my app's dependency to that version rather than the live version of the browser-sdk.
I have gone over the contributing documentation.