-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REPLAY-149] implement ViewEnd record #711
Conversation
The BEFORE_UNLOAD will have a side effect of generating another record. Change the strategy to simply expire the event, which shouldn't have any side effect in the long term.
f14c9e2
to
636c9d3
Compare
Recorder tests are skiped on IE, but we still need a syntax-compatible bundle.
7531406
to
cdbb3c4
Compare
Also, make sure the ending view id is used in the segment meta instead of the new view id.
This reverts commit a720320.
Codecov Report
@@ Coverage Diff @@
## master #711 +/- ##
==========================================
- Coverage 79.98% 79.88% -0.11%
==========================================
Files 69 69
Lines 3433 3440 +7
Branches 732 732
==========================================
+ Hits 2746 2748 +2
- Misses 687 692 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation
This is part of multitab tracking strategy. To let the player know a view has ended, a new record is added when the view ends or before unloading the page.
Note
There is some limitations with this strategy:
The player will need to be aware of this and handle it gracefully.
Changes
Testing
Unit + Manual
I have gone over the contributing documentation.