⚡️ [RUMF-841] remove session renew support in rum recorder #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the session is renewed, a new View is created. This commit removes unneeded callbacks invoked when the session is renewed, since they are already triggered when a view is created.
bcaudan
approved these changes
Feb 3, 2021
…pshot-on-session-renew
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When the session is renewed, a new View is created. In the RUM recorder, we are subscribing to both events, so we run the same action twice when a session is renewed.
Changes
This commit removes unneeded callbacks invoked when the session is renewed, since they are already triggered when a view is created.
Testing
Manual
I have gone over the contributing documentation.