🔥 Remove unused parameters

.eslintrc.js

@@ -98,7 +98,7 @@ module.exports = {
     '@typescript-eslint/no-parameter-properties': 'off',
     '@typescript-eslint/no-unsafe-assignment': 'off',
     '@typescript-eslint/no-unsafe-member-access': 'off',
-    '@typescript-eslint/no-unused-vars': 'error',
+    '@typescript-eslint/no-unused-vars': ['error', { args: 'all', argsIgnorePattern: '^_', vars: 'all' }],
     '@typescript-eslint/no-use-before-define': 'off',
     '@typescript-eslint/promise-function-async': 'off',
     '@typescript-eslint/quotes': 'off',

packages/core/src/tools/utils.ts

@@ -165,7 +165,7 @@ export function jsonStringify(
 
   let result: string
   try {
-    result = JSON.stringify(value, undefined, space)
+    result = JSON.stringify(value, replacer, space)
   } catch {
     result = '<error: unable to serialize object>'
   } finally {

packages/logs/src/boot/logs.entry.spec.ts

@@ -13,7 +13,7 @@ describe('logs entry', () => {
     ) => void
   >
   let startLogsGetGlobalContext: (() => Context) | undefined
-  const startLogs: StartLogs = (configuration, logger, getGlobalContext) => {
+  const startLogs: StartLogs = (_configuration, _logger, getGlobalContext) => {
     startLogsGetGlobalContext = getGlobalContext
     return (sendLogsSpy as any) as ReturnType<StartLogs>
   }

packages/logs/webpack.config.js

@@ -4,7 +4,7 @@ const webpackBase = require('../../webpack.base')
 
 const entry = path.resolve(__dirname, 'src/boot/logs.entry.ts')
 
-module.exports = (env, argv) => [
+module.exports = (_env, argv) => [
   webpackBase({ mode: argv.mode, entry, datacenter: 'us', filename: 'datadog-logs.js' }),
   webpackBase({ mode: argv.mode, entry, datacenter: 'us', filename: 'datadog-logs-us.js' }),
   webpackBase({ mode: argv.mode, entry, datacenter: 'eu', filename: 'datadog-logs-eu.js' }),

packages/rum-core/src/boot/rum.ts

@@ -73,8 +73,8 @@ export function startRumEventCollection(
   const batch = startRumBatch(configuration, lifeCycle)
   startRumAssembly(applicationId, configuration, lifeCycle, session, parentContexts, getCommonContext)
   startLongTaskCollection(lifeCycle)
-  startResourceCollection(lifeCycle, configuration, session)
-  const { addTiming } = startViewCollection(lifeCycle, configuration, location)
+  startResourceCollection(lifeCycle, session)
+  const { addTiming } = startViewCollection(lifeCycle, location)
   const { addError } = startErrorCollection(lifeCycle, configuration)
   const { addAction } = startActionCollection(lifeCycle, configuration)
 

packages/rum-core/src/domain/rumEventsCollection/error/errorCollection.spec.ts

@@ -13,8 +13,8 @@ describe('error collection', () => {
       .withConfiguration({
         isEnabled: () => true,
       })
-      .beforeBuild(({ lifeCycle, configuration }) => {
-        ;({ addError } = doStartErrorCollection(lifeCycle, configuration, errorObservable))
+      .beforeBuild(({ lifeCycle }) => {
+        ;({ addError } = doStartErrorCollection(lifeCycle, errorObservable))
       })
   })
 

packages/rum-core/src/domain/rumEventsCollection/error/errorCollection.ts

@@ -21,14 +21,10 @@ export interface ProvidedError {
 export type ProvidedSource = 'custom' | 'network' | 'source'
 
 export function startErrorCollection(lifeCycle: LifeCycle, configuration: Configuration) {
-  return doStartErrorCollection(lifeCycle, configuration, startAutomaticErrorCollection(configuration))
+  return doStartErrorCollection(lifeCycle, startAutomaticErrorCollection(configuration))
 }
 
-export function doStartErrorCollection(
-  lifeCycle: LifeCycle,
-  configuration: Configuration,
-  observable: Observable<RawError>
-) {
+export function doStartErrorCollection(lifeCycle: LifeCycle, observable: Observable<RawError>) {
   observable.subscribe((error) => lifeCycle.notify(LifeCycleEventType.RAW_RUM_EVENT_COLLECTED, processError(error)))
 
   return {

packages/rum-core/src/domain/rumEventsCollection/resource/resourceCollection.spec.ts

@@ -21,8 +21,8 @@ describe('resourceCollection', () => {
         .withConfiguration({
           isEnabled: () => true,
         })
-        .beforeBuild(({ lifeCycle, configuration, session }) => {
-          startResourceCollection(lifeCycle, configuration, session)
+        .beforeBuild(({ lifeCycle, session }) => {
+          startResourceCollection(lifeCycle, session)
         })
     })
 
@@ -94,8 +94,8 @@ describe('resourceCollection', () => {
         .withConfiguration({
           isEnabled: () => true,
         })
-        .beforeBuild(({ lifeCycle, configuration, session }) => {
-          startResourceCollection(lifeCycle, configuration, session)
+        .beforeBuild(({ lifeCycle, session }) => {
+          startResourceCollection(lifeCycle, session)
         })
     })
 
@@ -131,8 +131,8 @@ describe('resourceCollection', () => {
         .withConfiguration({
           isEnabled: () => true,
         })
-        .beforeBuild(({ lifeCycle, configuration, session }) => {
-          startResourceCollection(lifeCycle, configuration, session)
+        .beforeBuild(({ lifeCycle, session }) => {
+          startResourceCollection(lifeCycle, session)
         })
     })
 
@@ -177,8 +177,8 @@ describe('resourceCollection', () => {
         .withConfiguration({
           isEnabled: () => true,
         })
-        .beforeBuild(({ lifeCycle, configuration, session }) => {
-          startResourceCollection(lifeCycle, configuration, session)
+        .beforeBuild(({ lifeCycle, session }) => {
+          startResourceCollection(lifeCycle, session)
         })
     })
 

packages/rum-core/src/domain/rumEventsCollection/resource/resourceCollection.ts

@@ -1,12 +1,4 @@
-import {
-  combine,
-  Configuration,
-  generateUUID,
-  getTimestamp,
-  msToNs,
-  RequestType,
-  ResourceType,
-} from '@datadog/browser-core'
+import { combine, generateUUID, getTimestamp, msToNs, RequestType, ResourceType } from '@datadog/browser-core'
 import { RumPerformanceResourceTiming } from '../../../browser/performanceCollection'
 import { RawRumResourceEvent, RumEventType } from '../../../rawRumEvent.types'
 import { LifeCycle, LifeCycleEventType } from '../../lifeCycle'
@@ -21,7 +13,7 @@ import {
   isRequestKind,
 } from './resourceUtils'
 
-export function startResourceCollection(lifeCycle: LifeCycle, configuration: Configuration, session: RumSession) {
+export function startResourceCollection(lifeCycle: LifeCycle, session: RumSession) {
   lifeCycle.subscribe(LifeCycleEventType.REQUEST_COMPLETED, (request: RequestCompleteEvent) => {
     if (session.isTrackedWithResource()) {
       lifeCycle.notify(LifeCycleEventType.RAW_RUM_EVENT_COLLECTED, processRequest(request))

packages/rum-core/src/domain/rumEventsCollection/view/viewCollection.spec.ts

@@ -12,8 +12,8 @@ describe('viewCollection', () => {
       .withConfiguration({
         isEnabled: () => true,
       })
-      .beforeBuild(({ lifeCycle, configuration }) => {
-        startViewCollection(lifeCycle, configuration, location)
+      .beforeBuild(({ lifeCycle }) => {
+        startViewCollection(lifeCycle, location)
       })
   })
 

packages/rum-core/src/domain/rumEventsCollection/view/viewCollection.ts

@@ -1,9 +1,9 @@
-import { Configuration, getTimestamp, isEmptyObject, mapValues, msToNs } from '@datadog/browser-core'
+import { getTimestamp, isEmptyObject, mapValues, msToNs } from '@datadog/browser-core'
 import { RawRumViewEvent, RumEventType } from '../../../rawRumEvent.types'
 import { LifeCycle, LifeCycleEventType } from '../../lifeCycle'
 import { trackViews, View } from './trackViews'
 
-export function startViewCollection(lifeCycle: LifeCycle, configuration: Configuration, location: Location) {
+export function startViewCollection(lifeCycle: LifeCycle, location: Location) {
   lifeCycle.subscribe(LifeCycleEventType.VIEW_UPDATED, (view) =>
     lifeCycle.notify(LifeCycleEventType.RAW_RUM_EVENT_COLLECTED, processViewUpdate(view))
   )

packages/rum-recorder/webpack.config.js

@@ -2,7 +2,7 @@ const path = require('path')
 
 const webpackBase = require('../../webpack.base')
 
-module.exports = (env, argv) =>
+module.exports = (_env, argv) =>
   webpackBase({
     mode: argv.mode,
     entry: path.resolve(__dirname, 'src/boot/recorder.entry.ts'),

packages/rum/webpack.config.js

@@ -4,7 +4,7 @@ const webpackBase = require('../../webpack.base')
 
 const entry = path.resolve(__dirname, 'src/boot/rum.entry.ts')
 
-module.exports = (env, argv) => [
+module.exports = (_env, argv) => [
   webpackBase({ mode: argv.mode, entry, datacenter: 'us', filename: 'datadog-rum.js' }),
   webpackBase({ mode: argv.mode, entry, datacenter: 'us', filename: 'datadog-rum-us.js' }),
   webpackBase({ mode: argv.mode, entry, datacenter: 'eu', filename: 'datadog-rum-eu.js' }),

scripts/generate-changelog.js

@@ -73,7 +73,7 @@ async function getChangesList() {
 
   const changesWithPullRequestLinks = changesWithEmojis.replace(
     /\(#(\d+)\)/gm,
-    (match, id) => `([#${id}](https://github.com/DataDog/browser-sdk/pull/${id}))`
+    (_, id) => `([#${id}](https://github.com/DataDog/browser-sdk/pull/${id}))`
   )
 
   return changesWithPullRequestLinks

test/app/webpack.config.js

@@ -1,6 +1,6 @@
 const path = require('path')
 
-module.exports = (env, argv) => ({
+module.exports = (_env, argv) => ({
   entry: './app.ts',
   module: {
     rules: [

test/e2e/lib/framework/httpServers.ts

@@ -98,7 +98,7 @@ async function instantiateServerOnPort(port: number): Promise<http.Server> {
 function createServerIdleWaiter(server: http.Server) {
   const idleWaiter = createIdleWaiter()
 
-  server.on('request', (req: http.IncomingMessage, res: http.ServerResponse) => {
+  server.on('request', (_, res: http.ServerResponse) => {
     idleWaiter.pushActivity(new Promise((resolve) => res.on('close', resolve)))
   })
 

test/e2e/lib/framework/serverApps/mock.ts

@@ -9,23 +9,23 @@ export function createMockServerApp(endpoints: Endpoints, setup: string) {
   app.use(cors())
   app.disable('etag') // disable automatic resource caching
 
-  app.get('/empty', (req, res) => {
+  app.get('/empty', (_req, res) => {
     res.end()
   })
 
-  app.get('/favicon.ico', (req, res) => {
+  app.get('/favicon.ico', (_req, res) => {
     res.end()
   })
 
-  app.get('/throw', (req, res) => {
+  app.get('/throw', (_req, res) => {
     res.status(500).send('Server error')
   })
 
-  app.get('/unknown', (req, res) => {
+  app.get('/unknown', (_req, res) => {
     res.status(404).send('Not found')
   })
 
-  app.get('/empty.css', (req, res) => {
+  app.get('/empty.css', (_req, res) => {
     res.header('content-type', 'text/css').end()
   })
 
@@ -46,24 +46,24 @@ export function createMockServerApp(endpoints: Endpoints, setup: string) {
     res.send(JSON.stringify(req.headers))
   })
 
-  app.get('/', (req, res) => {
+  app.get('/', (_req, res) => {
     res.send(setup)
     res.end()
   })
 
-  app.get('/datadog-logs.js', async (req, res) => {
+  app.get('/datadog-logs.js', async (_req, res) => {
     res.header('content-type', 'application/javascript').send(await buildLogs(endpoints))
   })
 
-  app.get('/datadog-rum.js', async (req, res) => {
+  app.get('/datadog-rum.js', async (_req, res) => {
     res.header('content-type', 'application/javascript').send(await buildRum(endpoints))
   })
 
-  app.get('/datadog-rum-recorder.js', async (req, res) => {
+  app.get('/datadog-rum-recorder.js', async (_req, res) => {
     res.header('content-type', 'application/javascript').send(await buildRumRecorder(endpoints))
   })
 
-  app.get('/app.js', async (req, res) => {
+  app.get('/app.js', async (_req, res) => {
     res.header('content-type', 'application/javascript').send(await buildNpm(endpoints))
   })