Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUMF-857] round CLS to 4 decimals #773

Merged
merged 3 commits into from
Mar 30, 2021
Merged

[RUMF-857] round CLS to 4 decimals #773

merged 3 commits into from
Mar 30, 2021

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Mar 26, 2021

Motivation

Having more than 4 decimals to the cumulative layout shift score produce more noise than value. Since this score is compared to minimum 0.1, the precision is still 3 orders of magnitude below, so it should be completly fine.

Changes

Round the cumulative layout shift score to 4 decimals.

Testing

Unit


I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner March 26, 2021 14:08
@codecov-io
Copy link

Codecov Report

Merging #773 (184214e) into master (4458339) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #773   +/-   ##
=======================================
  Coverage   86.48%   86.48%           
=======================================
  Files          76       76           
  Lines        3573     3574    +1     
  Branches      820      821    +1     
=======================================
+ Hits         3090     3091    +1     
  Misses        483      483           
Impacted Files Coverage Δ
packages/core/src/tools/utils.ts 89.40% <100.00%> (ø)
.../src/domain/rumEventsCollection/view/trackViews.ts 97.38% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4458339...184214e. Read the comment docs.

@BenoitZugmeyer BenoitZugmeyer merged commit b3a24e5 into master Mar 30, 2021
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/round-cls branch March 30, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants