Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUMF-863] Enable console error with stack traces #781

Merged
merged 5 commits into from
Apr 6, 2021

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Apr 2, 2021

Motivation

cf #762:

  • remove error stack from raw error message
  • set raw error stack to first error instance stack

Changes

Remove feature flag + outdated tests

Testing

unit


I have gone over the contributing documentation.

@bcaudan bcaudan requested a review from a team as a code owner April 2, 2021 09:38
@codecov-io
Copy link

Codecov Report

Merging #781 (b020e25) into master (ea52019) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #781      +/-   ##
==========================================
- Coverage   86.33%   86.31%   -0.02%     
==========================================
  Files          76       76              
  Lines        3614     3611       -3     
  Branches      833      832       -1     
==========================================
- Hits         3120     3117       -3     
  Misses        494      494              
Impacted Files Coverage Δ
...ckages/core/src/domain/automaticErrorCollection.ts 98.59% <100.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea52019...b020e25. Read the comment docs.

@bcaudan bcaudan merged commit 22d6dba into master Apr 6, 2021
@bcaudan bcaudan deleted the bcaudan/remove-console-ff branch April 6, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants