Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 allow 1 ms error for matching request #824

Merged
merged 2 commits into from
May 3, 2021
Merged

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Apr 30, 2021

Motivation

Flaky e2e tests put in evidence that timing associated to an instrumented request can not alway be perfectly nested.
Observed case:

Req start     593.3949999
Timing start  593.5950000
Req end       799.3949999
Timing end    799.5550000

Changes

Allow a 1 ms error margin in the matching condition.

Testing

unit + ci


I have gone over the contributing documentation.

@bcaudan bcaudan requested a review from a team as a code owner April 30, 2021 14:11
@codecov-commenter
Copy link

Codecov Report

Merging #824 (5470b2f) into master (cf5109a) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #824      +/-   ##
==========================================
- Coverage   86.87%   86.72%   -0.16%     
==========================================
  Files          80       80              
  Lines        3871     3872       +1     
  Branches      879      879              
==========================================
- Hits         3363     3358       -5     
- Misses        508      514       +6     
Impacted Files Coverage Δ
...rumEventsCollection/resource/matchRequestTiming.ts 95.45% <100.00%> (+0.21%) ⬆️
packages/rum-core/src/transport/batch.ts 62.85% <0.00%> (-11.43%) ⬇️
packages/rum-core/src/domain/parentContexts.ts 98.24% <0.00%> (-1.76%) ⬇️
...ckages/core/src/domain/automaticErrorCollection.ts 98.59% <0.00%> (-1.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf5109a...5470b2f. Read the comment docs.

@bcaudan bcaudan merged commit e9bb03c into master May 3, 2021
@bcaudan bcaudan deleted the bcaudan/flaky-1 branch May 3, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants