Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Clear previously set user context #840

Merged
merged 3 commits into from
May 12, 2021

Conversation

amortemousque
Copy link
Contributor

@amortemousque amortemousque commented May 11, 2021

Motivation

Provide an API to clear a previously set user without having to clear all its attributes.
#774

Changes

Allows you to clear a previously set user with the API removeUser()

Testing

Unit, manual


I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner May 11, 2021 13:51
@bits-bot
Copy link

bits-bot commented May 11, 2021

CLA assistant check
All committers have signed the CLA.

@amortemousque amortemousque force-pushed the aymeric/clear-previously-set-user-context branch from 18a6922 to 7d93714 Compare May 11, 2021 14:06
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2021

Codecov Report

Merging #840 (714b862) into main (37332ae) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #840      +/-   ##
==========================================
- Coverage   86.81%   86.67%   -0.15%     
==========================================
  Files          82       82              
  Lines        3914     3916       +2     
  Branches      884      884              
==========================================
- Hits         3398     3394       -4     
- Misses        516      522       +6     
Impacted Files Coverage Δ
packages/rum-core/src/boot/rumPublicApi.ts 94.25% <100.00%> (+0.13%) ⬆️
packages/rum-core/src/transport/batch.ts 62.85% <0.00%> (-11.43%) ⬇️
...omain/rumEventsCollection/error/errorCollection.ts 95.00% <0.00%> (-5.00%) ⬇️
...ckages/core/src/domain/automaticErrorCollection.ts 98.27% <0.00%> (-1.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37332ae...714b862. Read the comment docs.

@amortemousque amortemousque force-pushed the aymeric/clear-previously-set-user-context branch from 7d93714 to f14e1f6 Compare May 11, 2021 14:09
@amortemousque amortemousque force-pushed the aymeric/clear-previously-set-user-context branch from f14e1f6 to a565a3f Compare May 11, 2021 15:18
@amortemousque amortemousque force-pushed the aymeric/clear-previously-set-user-context branch from a565a3f to 714b862 Compare May 11, 2021 15:51
Copy link
Contributor

@bcaudan bcaudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@amortemousque amortemousque merged commit e5cf694 into main May 12, 2021
@amortemousque amortemousque deleted the aymeric/clear-previously-set-user-context branch May 12, 2021 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants