-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚗ [RUMF-878] add startView API #850
Conversation
tedious to follow where are declared methods used publicly so remove one step
behind `view-renaming` flag
4568ba1
to
19fca95
Compare
Codecov Report
@@ Coverage Diff @@
## main #850 +/- ##
==========================================
- Coverage 88.96% 88.57% -0.39%
==========================================
Files 80 80
Lines 3642 3651 +9
Branches 804 806 +2
==========================================
- Hits 3240 3234 -6
- Misses 402 417 +15
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a good start. Two notes:
-
I think we should ensure that the initial document resource is attached to the initial view instead of the latest created view, since now views can be created before
init()
. It should be the case, but a unit test to ensure it could be nice. -
I'm mitigated about the function name. I kind of liked
newView
. What made you change your mind from the RFC proposal?
packages/rum-core/src/domain/rumEventsCollection/view/trackViews.ts
Outdated
Show resolved
Hide resolved
4437047
to
818db55
Compare
349fe5b
to
140e12e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice !
Motivation
First step in the manual view naming strategy
Changes
behind
view-renaming
flag, introduce new API:Allowing to manually start a new view with an optional name
Testing
unit / manual
I have gone over the contributing documentation.