-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚡️ [RUMF-767] start mutation observer only when needed #858
Merged
amortemousque
merged 23 commits into
main
from
aymeric/start-mutation-observer-only-when-needed
Jun 1, 2021
Merged
⚡️ [RUMF-767] start mutation observer only when needed #858
amortemousque
merged 23 commits into
main
from
aymeric/start-mutation-observer-only-when-needed
Jun 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amortemousque
force-pushed
the
aymeric/start-mutation-observer-only-when-needed
branch
2 times, most recently
from
May 19, 2021 15:46
9d25946
to
0841bdd
Compare
bcaudan
reviewed
May 20, 2021
amortemousque
force-pushed
the
aymeric/start-mutation-observer-only-when-needed
branch
from
May 20, 2021 15:05
0b7efb9
to
4122695
Compare
Codecov Report
@@ Coverage Diff @@
## main #858 +/- ##
==========================================
- Coverage 88.62% 88.58% -0.04%
==========================================
Files 80 80
Lines 3656 3671 +15
Branches 809 812 +3
==========================================
+ Hits 3240 3252 +12
- Misses 416 419 +3
Continue to review full report at Codecov.
|
bcaudan
reviewed
May 25, 2021
amortemousque
force-pushed
the
aymeric/start-mutation-observer-only-when-needed
branch
from
May 28, 2021 10:51
fb92d97
to
107ac9c
Compare
bcaudan
reviewed
May 28, 2021
packages/rum-core/src/domain/rumEventsCollection/action/trackActions.spec.ts
Outdated
Show resolved
Hide resolved
bcaudan
approved these changes
May 31, 2021
amortemousque
deleted the
aymeric/start-mutation-observer-only-when-needed
branch
June 7, 2021 15:44
bcaudan
changed the title
⚡️ start mutation observer only when needed
⚡️ [RUMF-767] start mutation observer only when needed
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Start MutationObserver only when needed for performance optimization
Changes
Testing
Unit, local
I have gone over the contributing documentation.