Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 do not break the recorder when an URL fails to parse #871

Merged
merged 3 commits into from
May 27, 2021

Conversation

BenoitZugmeyer
Copy link
Member

Motivation

The RUM recorder tries to transform URLs in attributes or CSS to make them absolute. Sometimes, the value passed as an URL fails to parse, and an error is thrown.

Changes

Just return the original value in this case.

Testing

Unit


I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner May 27, 2021 14:07
@codecov-commenter
Copy link

Codecov Report

Merging #871 (61a516f) into main (a1f35ac) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #871   +/-   ##
=======================================
  Coverage   88.61%   88.62%           
=======================================
  Files          80       80           
  Lines        3654     3656    +2     
  Branches      809      809           
=======================================
+ Hits         3238     3240    +2     
  Misses        416      416           
Impacted Files Coverage Δ
...m-recorder/src/domain/record/serializationUtils.ts 95.23% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1f35ac...61a516f. Read the comment docs.

@BenoitZugmeyer BenoitZugmeyer merged commit 28317a7 into main May 27, 2021
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/fix-invalid-links-parsing branch May 27, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants