✨ [RUMF-921] differentiate handled and unhandled errors #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amortemousque
changed the title
Codecov Report
@@ Coverage Diff @@
## main #886 +/- ##
==========================================
+ Coverage 89.09% 89.12% +0.03%
==========================================
Files 81 81
Lines 3787 3790 +3
Branches 845 846 +1
==========================================
+ Hits 3374 3378 +4
+ Misses 413 412 -1
Continue to review full report at Codecov.
|
amortemousque
force-pushed
the
aymeric/differentiate-handled-and-not—handled-errors
branch
from
d7853c8 to
cceb0e7
Compare
bcaudan
reviewed
Jun 11, 2021
| /** | ||
| * Whether the error has been handled manually in the source code or not | ||
| */ | ||
| readonly handling?: 'handled' | 'unhandled' |
There was a problem hiding this comment.
should we also add this field to logs error?
There was a problem hiding this comment.
I've asked Maxime and for him, it's good enough for now.
bcaudan
deleted the
aymeric/differentiate-handled-and-not—handled-errors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the context of RUM, an error is considered handled as long as it has been reported manually in the code (e.g console.error, rumAgent.addError). Errors collected through global error/exception listeners are considered unhandled.
This new tag differentiate handled and unhandled errors.
Changes
Add
handlingflag to all errors reported by RUM except Network and Agent errorsTesting
Unit, Locally
I have gone over the contributing documentation.