🐛 [RUMF-931] check if PerformanceEntry is defined before using it #891
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When implementing #883, we needed to use the global
PerformanceEntry
class. This class is not supported in Safari 10 and below.Fix #890
Changes
Check if
PerformanceEntry
is defined before using it.Testing
CI, manual (browser stack live with Safari 10)
Note
This should have been an internal error, but because of the
await
used in thefetchProxy
, it ends up as an "unhandled rejection" (anything executed after the await is not "monitored"). We should address this issue in a separate PR.I have gone over the contributing documentation.