[RUMF-937] create the rum-slim package #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayayarai
approved these changes
Jul 12, 2021
webNeat
approved these changes
Jul 13, 2021
bcaudan
reviewed
Jul 15, 2021
test/e2e/lib/framework/createTest.ts
Outdated
| declareTest(name!, factory(setupOptions), runner) | ||
| } | ||
| declareTestsForSetups('rum', setups, setupOptions, runner) | ||
| declareTestsForSetups('rum-slim', setups, { ...setupOptions, useRumSlim: true }, runner) |
There was a problem hiding this comment.
no need to run slim on npm, right?
rum
✓ async
✓ npm
✓ bundle
rum-slim
✓ async
✓ npm
✓ bundle
bcaudan
approved these changes
Jul 15, 2021
amortemousque
pushed a commit
that referenced
this pull request
Jul 20, 2021
amortemousque
pushed a commit
that referenced
this pull request
Jul 20, 2021
amortemousque
pushed a commit
that referenced
this pull request
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add a package similar to the current rum package, that won't contain the recorder once the V3 is released.
Changes
Create a new rum-slim package based on rum-core. This is a clone of the rum package with another name.
Testing
I have gone over the contributing documentation.