Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💥 remove addError 'source' argument #936

Merged

Conversation

amortemousque
Copy link
Contributor

@amortemousque amortemousque commented Jul 13, 2021

Motivation

In order to avoid any confusion on how to enrich RUM data, we advice user to use addError context attribut.
In that regard, all errors captured with addError are now classified as custom.

Changes

Remove addError 'source' argument

Testing

Unit, Locally


I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner July 13, 2021 08:28
@amortemousque amortemousque force-pushed the aymeric/remove-addError-source-argument branch from b482493 to 96543bc Compare July 13, 2021 09:03
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2021

Codecov Report

Merging #936 (e033d81) into prerelease-v3 (934166a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           prerelease-v3     #936      +/-   ##
=================================================
- Coverage          89.02%   89.01%   -0.02%     
=================================================
  Files                 82       82              
  Lines               3864     3860       -4     
  Branches             865      863       -2     
=================================================
- Hits                3440     3436       -4     
  Misses               424      424              
Impacted Files Coverage Δ
packages/rum-core/src/boot/rumPublicApi.ts 94.84% <100.00%> (-0.21%) ⬇️
...omain/rumEventsCollection/error/errorCollection.ts 70.37% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 934166a...e033d81. Read the comment docs.

@amortemousque amortemousque force-pushed the aymeric/remove-addError-source-argument branch from 96543bc to e033d81 Compare July 13, 2021 09:21
@amortemousque amortemousque changed the title 💥 Remove addError 'source' argument 💥 remove addError 'source' argument Jul 13, 2021
@amortemousque amortemousque merged commit 6875077 into prerelease-v3 Jul 13, 2021
@bcaudan bcaudan deleted the aymeric/remove-addError-source-argument branch September 13, 2021 08:07
alk-mandrianarijaona added a commit to alk-mandrianarijaona/documentation that referenced this pull request Nov 30, 2021
jtappa pushed a commit to DataDog/documentation that referenced this pull request Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants