-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💥 remove addError 'source' argument #936
Merged
amortemousque
merged 1 commit into
prerelease-v3
from
aymeric/remove-addError-source-argument
Jul 13, 2021
Merged
💥 remove addError 'source' argument #936
amortemousque
merged 1 commit into
prerelease-v3
from
aymeric/remove-addError-source-argument
Jul 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amortemousque
force-pushed
the
aymeric/remove-addError-source-argument
branch
from
July 13, 2021 09:03
b482493
to
96543bc
Compare
Codecov Report
@@ Coverage Diff @@
## prerelease-v3 #936 +/- ##
=================================================
- Coverage 89.02% 89.01% -0.02%
=================================================
Files 82 82
Lines 3864 3860 -4
Branches 865 863 -2
=================================================
- Hits 3440 3436 -4
Misses 424 424
Continue to review full report at Codecov.
|
amortemousque
force-pushed
the
aymeric/remove-addError-source-argument
branch
from
July 13, 2021 09:21
96543bc
to
e033d81
Compare
BenoitZugmeyer
approved these changes
Jul 13, 2021
webNeat
approved these changes
Jul 13, 2021
amortemousque
changed the title
💥 Remove addError 'source' argument
💥 remove addError 'source' argument
Jul 13, 2021
bcaudan
approved these changes
Jul 13, 2021
amortemousque
added a commit
that referenced
this pull request
Jul 20, 2021
amortemousque
added a commit
that referenced
this pull request
Jul 21, 2021
alk-mandrianarijaona
added a commit
to alk-mandrianarijaona/documentation
that referenced
this pull request
Nov 30, 2021
this argument was removed at DataDog/browser-sdk#936
4 tasks
jtappa
pushed a commit
to DataDog/documentation
that referenced
this pull request
Dec 2, 2021
this argument was removed at DataDog/browser-sdk#936
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In order to avoid any confusion on how to enrich RUM data, we advice user to use addError
context
attribut.In that regard, all errors captured with addError are now classified as custom.
Changes
Remove addError 'source' argument
Testing
Unit, Locally
I have gone over the contributing documentation.