Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💥 always use alternative domains for RUM #944

Merged

Conversation

amortemousque
Copy link
Contributor

Motivation

In the context of the version 3 always use alternative domains.

Changes

Remove useAlternateIntakeDomains option

Testing

Unit, Locally


I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner July 15, 2021 15:35
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This options defaults to false, so you should set it to true to always use the alternative domains

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2021

Codecov Report

Merging #944 (7363f57) into prerelease-v3 (a65794c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           prerelease-v3     #944   +/-   ##
==============================================
  Coverage          89.08%   89.08%           
==============================================
  Files                 83       83           
  Lines               3868     3868           
  Branches             857      857           
==============================================
  Hits                3446     3446           
  Misses               422      422           
Impacted Files Coverage Δ
packages/rum-core/src/boot/rumPublicApi.ts 97.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a65794c...7363f57. Read the comment docs.

@amortemousque amortemousque merged commit 1ddb165 into prerelease-v3 Jul 19, 2021
amortemousque added a commit that referenced this pull request Jul 20, 2021
* 💥 Remove useAlternateIntakeDomains option from RUM

* 👌 Set useAlternateIntakeDomains to true for RUM
amortemousque added a commit that referenced this pull request Jul 20, 2021
* 💥 Remove useAlternateIntakeDomains option from RUM

* 👌 Set useAlternateIntakeDomains to true for RUM
amortemousque added a commit that referenced this pull request Jul 21, 2021
* 💥 Remove useAlternateIntakeDomains option from RUM

* 👌 Set useAlternateIntakeDomains to true for RUM
BenoitZugmeyer added a commit that referenced this pull request Jul 27, 2021
BenoitZugmeyer added a commit that referenced this pull request Jul 27, 2021
…963)

* Revert "💥 always use alternative domains for RUM (#944)"

This reverts commit 6fd361c.

* remove classic endpoints deprecation from the CHANGELOG
@amortemousque amortemousque deleted the aymeric/remove-useAlternateIntakeDomains-for-RUM branch September 21, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants