Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚗ [RUMF-971] experiment to detect when the computer goes to sleep #976

Merged
merged 8 commits into from
Aug 4, 2021

Conversation

BenoitZugmeyer
Copy link
Member

Motivation

This is part of an investigation where we observed abnormally high resource durations and web vital timings

Changes

Add an experimental way to detect when the computer goes to sleep. Use it on resources and internal monitoring logs to help investigation.

Testing

Unit, manual


I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner August 4, 2021 09:14
@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2021

Codecov Report

Merging #976 (83b510a) into main (d9fa056) will decrease coverage by 0.02%.
The diff coverage is 87.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #976      +/-   ##
==========================================
- Coverage   88.92%   88.90%   -0.03%     
==========================================
  Files          83       84       +1     
  Lines        3874     3902      +28     
  Branches      858      864       +6     
==========================================
+ Hits         3445     3469      +24     
- Misses        429      433       +4     
Impacted Files Coverage Δ
packages/rum-core/src/boot/startRum.ts 34.48% <0.00%> (-2.56%) ⬇️
...main/rumEventsCollection/resource/resourceUtils.ts 94.66% <ø> (ø)
...umEventsCollection/view/trackInitialViewTimings.ts 96.66% <ø> (ø)
packages/rum-core/src/rawRumEvent.types.ts 100.00% <ø> (ø)
...rumEventsCollection/resource/resourceCollection.ts 94.87% <75.00%> (-2.28%) ⬇️
packages/rum-core/src/domain/trackSleep.ts 95.45% <95.45%> (ø)
packages/core/src/domain/internalMonitoring.ts 95.52% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9fa056...83b510a. Read the comment docs.

Copy link
Contributor

@bcaudan bcaudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/rum-core/src/domain/trackSleep.ts Outdated Show resolved Hide resolved
@BenoitZugmeyer BenoitZugmeyer merged commit 2916261 into main Aug 4, 2021
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/track-sleep branch August 4, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants