-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit log monitoring + add more details #990
Conversation
Codecov Report
@@ Coverage Diff @@
## main #990 +/- ##
==========================================
- Coverage 88.86% 88.83% -0.04%
==========================================
Files 84 84
Lines 3908 3913 +5
Branches 864 866 +2
==========================================
+ Hits 3473 3476 +3
- Misses 435 437 +2
Continue to review full report at Codecov.
|
@@ -14,6 +14,7 @@ import { InForegroundPeriod } from '../rawRumEvent.types' | |||
|
|||
// Arbitrary value to cap number of element (mostly for backend) | |||
export const MAX_NUMBER_OF_FOCUSED_TIME = 500 | |||
const MAX_LAG_TIME = 10 as RelativeTime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment to explain your limiting strategy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because of this chrome bug. It currently dispatches two events separated by ~1ms. I've set it at 10ms to be large & because if our foreground periods are off by 10ms we do not really care.
I also added the now in the log to actually get an insight by how much we're off. I am not really fixing the base issue, just ignoring this chrome bug & adding monitoring info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation
Too much logging in the foregroundContext manager
Changes