Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added recipe for go_expvar metrics collection #298

Merged

Conversation

hartfordfive
Copy link
Contributor

No description provided.

@miketheman
Copy link
Contributor

Hi @hartfordfive !

Can you please take a look at the approach for spec testing (vs kitchen) for integrations here: #295.

Also, we've adopted a very flexible method for templates, please follow this example: https://github.com/DataDog/chef-datadog/blob/4e59a32c7b692e8d4cf99bfb927af1de9e2c0118/templates/default/docker_daemon.yaml.erb

This leaves any further updates to the template to be attributes only, controlled by the end user, with no updates to the cookbook.

@hartfordfive
Copy link
Contributor Author

HI @miketheman, I'll make the necessary modifications and then push the updated code. Thanks.

@hartfordfive
Copy link
Contributor Author

@miketheman from what I can tell, the current CircleCI failure doesn't seem to be caused by anything in modifications, unless i'm missing something?

@miketheman
Copy link
Contributor

@hartfordfive I think it's because your branch is off the last release 2.2.0 - 4e59a32 instead of current master branch.

A rebase should solve it.

@miketheman miketheman merged commit 6c0d3e6 into DataDog:master Apr 21, 2016
@miketheman miketheman added this to the Next minor milestone Apr 21, 2016
@miketheman
Copy link
Contributor

@hartfordfive Thanks! I squashed the commits and merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants