Ignore rate limiting errors in logs when checking for new releases #201
+196
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ishirui
approved these changes
Oct 6, 2025
src/dda/cli/application.py
Outdated
| response = client.get("https://api.github.com/repos/DataDog/datadog-agent-dev/releases/latest") | ||
| except httpx.HTTPStatusError as e: | ||
| github_auth = self.__app.config.github.auth | ||
| # Ignore rate limiting errors if the user has not authenticated |
There was a problem hiding this comment.
Why not ignore rate limiting errors all the time ?
ofek
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Oct 6, 2025
) * Ignore unauthenticated rate limiting errors in logs * address review 8d40ad2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking for new releases there's no point in displaying rate limiting errors if GitHub auth has not been configured.