[AD] port/deprecate Agent5 SD features

[xvello]

Here's a list of the features / edge cases found in the Agent5 codebase. I think we should aim for sanity over feature parity, but listing them all will allow us to better communicate on what we deprecate. This issue can be closed once all tracking cards are created.

Please directly update the issue itself to strike items when ported or deprecated.

Common

• ✅ Docker inspect caching
• ✅ Optional template tokens:
  • ✅ %%pid%%
  • %%host[n]%%
    • ✅ extract IP from docker networks
    • extract IP from K8 pod info
    • extract IP from Rancher 1.x container label
  • %%port[n]%%
  • 🔥 %%container-name%%
  • 🔥 %%tags%% : node_name, pod_name, kube_container_name : should we rename / split up / deprecate ?
• Reload changed containers: two use cases:
  • 🔥 used by docker_daemon.py for new and deleted containers → superseeded by DockerListener
  • used by kubernetes.py to refresh kube_service tags → study alternatives
  • not used when K/V store templates are updated, full reload
• Full AD reload and re-match mechanism. Used for reload after k/v store changes
• ✅ Container tags from docker + orchestrators
• Support several instances of one check per template
• ✅ Pluggable detection backend → ServiceListener interface
• Keep track of the template source (file/annotation/template) for display in checkconf
• is_jmx only work for file templates, not annotations / k/v store, should be solved

Auto_conf mode

• ✅ Templates as yaml files
• Templates in Kubernetes annotations and in Docker labels : overrides template file lookup
• Providing a com.datadoghq.sd.check.id docker label to override image name
• Matches short image name only (no prefix / tag), should be changed to long-or-short

K/V store mode

• ✅ Pluggable k/v store sources → ConfigProvider interface
• Support several checks in one template
• Fallback to auto_conf templates if k/v does not match
• Lookups long name, then short image name (no prefix / tag). Final lookup order is k/v-long, autoconf-long, k/v-short, autoconf-short
• Annotations are ignored in k/v mode, should that still be the case?

[masci]

@xvello this seems outdated, can we close?

[xvello]

Indeed, added a backlog item for the last one: rancher IP

[andrewloux]

@xvello Used to use the following in a check's tag list to extract pod_name

%%tags%% : node_name, pod_name, kube_container_name : should we rename / split up / deprecate ?

Reading through the v6 codebase trying to grok what the alternative in v6 looks like - do you have any input?