Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] upgrade opa rego to v0.37.2 #10557

Merged
merged 6 commits into from
Feb 11, 2022
Merged

Conversation

paulcacheux
Copy link
Contributor

@paulcacheux paulcacheux commented Jan 17, 2022

What does this PR do?

This PR upgrades the rego evaluator dependency.

This bump was tested on the security-monitoring rego testsuite

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • The appropriate team/.. label has been applied, if known.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the config template has been updated.

@paulcacheux paulcacheux added this to the 7.35.0 milestone Jan 17, 2022
@paulcacheux paulcacheux force-pushed the paulcacheux/upgrade-rego-lib-36-1 branch from c1a194c to e52ce7f Compare January 17, 2022 16:20
@paulcacheux paulcacheux force-pushed the paulcacheux/upgrade-rego-lib-36-1 branch from e52ce7f to 47523b1 Compare January 31, 2022 17:01
@paulcacheux paulcacheux added the dependencies PRs that bump a dependency label Jan 31, 2022
@paulcacheux paulcacheux marked this pull request as ready for review January 31, 2022 18:19
@paulcacheux paulcacheux force-pushed the paulcacheux/upgrade-rego-lib-36-1 branch from 47523b1 to 4f0b033 Compare February 7, 2022 10:26
@paulcacheux paulcacheux force-pushed the paulcacheux/upgrade-rego-lib-36-1 branch from 4f0b033 to 2085122 Compare February 8, 2022 13:03
@paulcacheux paulcacheux changed the title [CWS] upgrade opa rego to v0.36.1 [CWS] upgrade opa rego to v0.37.1 Feb 8, 2022
@paulcacheux paulcacheux requested review from lebauce and mx-psi February 8, 2022 15:24
@paulcacheux
Copy link
Contributor Author

@mx-psi I asked a review from you because of the changes to other dependencies that this bump brings. One dependency in particular seems to be the prometheus client. Looking at the changelog it seems that v1.12.0 actually adds support for Go 1.17 so maybe we actually need it ?

@mx-psi
Copy link
Member

mx-psi commented Feb 8, 2022

I don't know which Prometheus features we use in the Agent, that is a question for Agent Core. If we use the feature updated in prometheus/client_golang#955 I think we should update indeed. In any case, I think this PR leaves us better (or at least not worse) than we currently are, so I will approve it!

@paulcacheux paulcacheux requested a review from a team February 8, 2022 16:07
@paulcacheux paulcacheux force-pushed the paulcacheux/upgrade-rego-lib-36-1 branch from 2085122 to ae5ae03 Compare February 11, 2022 10:05
@paulcacheux paulcacheux changed the title [CWS] upgrade opa rego to v0.37.1 [CWS] upgrade opa rego to v0.37.2 Feb 11, 2022
go.mod Outdated Show resolved Hide resolved
@paulcacheux paulcacheux merged commit 28b15f6 into main Feb 11, 2022
@paulcacheux paulcacheux deleted the paulcacheux/upgrade-rego-lib-36-1 branch February 11, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants