-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CWS] upgrade opa rego to v0.37.2 #10557
Conversation
c1a194c
to
e52ce7f
Compare
e52ce7f
to
47523b1
Compare
47523b1
to
4f0b033
Compare
4f0b033
to
2085122
Compare
@mx-psi I asked a review from you because of the changes to other dependencies that this bump brings. One dependency in particular seems to be the prometheus client. Looking at the changelog it seems that v1.12.0 actually adds support for Go 1.17 so maybe we actually need it ? |
I don't know which Prometheus features we use in the Agent, that is a question for Agent Core. If we use the feature updated in prometheus/client_golang#955 I think we should update indeed. In any case, I think this PR leaves us better (or at least not worse) than we currently are, so I will approve it! |
2085122
to
ae5ae03
Compare
What does this PR do?
This PR upgrades the rego evaluator dependency.
This bump was tested on the
security-monitoring
rego testsuiteMotivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
Triage
milestone is set.team/..
label has been applied, if known.major_change
label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changelog
label has been applied.qa/skip-qa
label is not applied.need-change/operator
andneed-change/helm
labels have been applied.