Fix invalid json in log #2139
Closed
Fix invalid json in log #2139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW I couldn't set up local dev environment, and had no time to figure out how to add tests for this. So... any help on this would be appreciated. |
|
Hi @chulkilee, Thanks a lot for this PR and sorry for the very long response time. The issue was fixed in #4004 (which was included in 6.14.0). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix invalid json in log.
https://github.com/DataDog/datadog-agent/blob/6.4.1/pkg/forwarder/transaction.go#L140 uses
%qfor log URL, which uses"in the log message. However, the message is just passed to seelog without escape.See cihub/seelog#161 - all changes are from it.
Motivation
It breaks JSON parsing in Logstash :(