Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[omnibus][automated] Bump OMNIBUS_SOFTWARE_VERSION #22277

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

agent-platform-auto-pr[bot]
Copy link
Contributor

Automatically created by merging DataDog/omnibus-software#498

@agent-platform-auto-pr agent-platform-auto-pr bot requested a review from a team as a code owner January 23, 2024 12:30
@agent-platform-auto-pr agent-platform-auto-pr bot added this to the 7.52.0 milestone Jan 23, 2024
@agent-platform-auto-pr agent-platform-auto-pr bot requested review from a team as code owners January 23, 2024 12:30
@chouquette chouquette added the [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card label Jan 23, 2024
Copy link
Member

@amenasria amenasria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Shouldn't we keep the final line break ?

@chouquette
Copy link
Contributor

chouquette commented Jan 23, 2024

LGTM ! Shouldn't we keep the final line break ?

That's an interesting question! That's what our tooling generates (ie there's no voluntarily addition/removal of final line break), but we could maybe edit it to append the newline. I'm not sure what the agreed upon behavior is, if any
I also suspect that we don't all share the same editor settings as this line keeps being removed/added 😅

@pr-commenter
Copy link

pr-commenter bot commented Jan 23, 2024

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 6517070c-771c-4ab3-a672-a9bfb7b82a0b
Baseline: 3e22616
Comparison: 7d68d69
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +1.71 [-4.94, +8.37]
file_tree memory utilization +0.83 [+0.76, +0.89]
idle memory utilization +0.31 [+0.28, +0.34]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
otel_to_otel_logs ingress throughput +3.39 [+2.65, +4.12]
file_to_blackhole % cpu utilization +1.71 [-4.94, +8.37]
file_tree memory utilization +0.83 [+0.76, +0.89]
uds_dogstatsd_to_api_cpu % cpu utilization +0.46 [-0.99, +1.91]
process_agent_standard_check_with_stats memory utilization +0.31 [+0.28, +0.35]
idle memory utilization +0.31 [+0.28, +0.34]
tcp_syslog_to_blackhole ingress throughput +0.11 [+0.04, +0.18]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.03, +0.03]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.06, +0.06]
trace_agent_msgpack ingress throughput -0.05 [-0.07, -0.03]
trace_agent_json ingress throughput -0.05 [-0.08, -0.03]
process_agent_real_time_mode memory utilization -0.56 [-0.59, -0.53]
process_agent_standard_check memory utilization -0.72 [-0.76, -0.67]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@chouquette
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 23, 2024

🚂 MergeQueue

Pull request added to the queue.

There are 5 builds ahead! (estimated merge in less than 1h)

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 3d9a977 into main Jan 23, 2024
178 of 179 checks passed
@dd-mergequeue dd-mergequeue bot deleted the automated/omnibus-software/498 branch January 23, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card [deprecated] team/agent-platform mergequeue-status: done qa/no-code-change No code change in Agent code requiring validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants