-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OTEL-1726] Add OTel span utils to tracetuil #24270
Conversation
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=31353161 --os-family=ubuntu |
Regression DetectorRegression Detector ResultsRun ID: 1c1eae89-9d7b-4066-9b99-01d9b79545c4 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | file_to_blackhole | % cpu utilization | -1.60 | [-7.34, +4.14] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | pycheck_1000_100byte_tags | % cpu utilization | +3.07 | [-1.93, +8.08] |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +1.32 | [-1.57, +4.21] |
➖ | trace_agent_json | ingress throughput | -0.00 | [-0.01, +0.01] |
➖ | trace_agent_msgpack | ingress throughput | -0.00 | [-0.00, +0.00] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.03, +0.03] |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.21, +0.19] |
➖ | process_agent_standard_check | memory utilization | -0.06 | [-0.10, -0.01] |
➖ | otel_to_otel_logs | ingress throughput | -0.10 | [-0.58, +0.37] |
➖ | process_agent_standard_check_with_stats | memory utilization | -0.19 | [-0.23, -0.15] |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.21 | [-0.29, -0.13] |
➖ | file_tree | memory utilization | -0.31 | [-0.41, -0.22] |
➖ | process_agent_real_time_mode | memory utilization | -0.37 | [-0.40, -0.33] |
➖ | idle | memory utilization | -0.38 | [-0.42, -0.35] |
➖ | file_to_blackhole | % cpu utilization | -1.60 | [-7.34, +4.14] |
➖ | basic_py_check | % cpu utilization | -1.83 | [-4.26, +0.59] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
628e542
to
b95822f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any thoughts on adding @DataDog/opentelemetry
as code owner of /pkg/trace/traceutil/otel*.go
in https://github.com/DataDog/datadog-agent/blob/main/.github/CODEOWNERS ?
Good point @ahmed-mez I updated the codeowners |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for ASC owned files
/merge |
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 24m) Use |
* [OTEL-1726] Add OTel span utils to tracetuil * Address review comments * Fix an import * Update codeowners
What does this PR do?
Add util functions on OTel span semantic conventions to tracetuil. These are extracted from
pkg/trace/api/otlp.go
Split from #23503
Motivation
Describe how to test/QA your changes
N/A QA is covered in #23503.