Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTEL-1726] Add OTel span utils to tracetuil #24270

Merged
merged 4 commits into from
Apr 3, 2024

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Apr 1, 2024

What does this PR do?

Add util functions on OTel span semantic conventions to tracetuil. These are extracted from pkg/trace/api/otlp.go

Split from #23503

Motivation

Describe how to test/QA your changes

N/A QA is covered in #23503.

@songy23 songy23 added this to the 7.54.0 milestone Apr 1, 2024
@songy23 songy23 requested review from dineshg13 and liustanley April 1, 2024 21:12
@songy23 songy23 requested review from a team as code owners April 1, 2024 21:12
Copy link

cit-pr-commenter bot commented Apr 1, 2024

Go Package Import Differences

Baseline: b33d483
Comparison: 3c4c0b8

binaryosarchchange
agentwindowsamd64
+1, -0
+go.opentelemetry.io/collector/semconv/v1.17.0
agentwindows386
+1, -0
+go.opentelemetry.io/collector/semconv/v1.17.0

@songy23 songy23 requested a review from a team as a code owner April 1, 2024 21:20
@pr-commenter
Copy link

pr-commenter bot commented Apr 1, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=31353161 --os-family=ubuntu

@pr-commenter
Copy link

pr-commenter bot commented Apr 1, 2024

Regression Detector

Regression Detector Results

Run ID: 1c1eae89-9d7b-4066-9b99-01d9b79545c4
Baseline: b33d483
Comparison: 3c4c0b8

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -1.60 [-7.34, +4.14]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
pycheck_1000_100byte_tags % cpu utilization +3.07 [-1.93, +8.08]
uds_dogstatsd_to_api_cpu % cpu utilization +1.32 [-1.57, +4.21]
trace_agent_json ingress throughput -0.00 [-0.01, +0.01]
trace_agent_msgpack ingress throughput -0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.03, +0.03]
uds_dogstatsd_to_api ingress throughput -0.01 [-0.21, +0.19]
process_agent_standard_check memory utilization -0.06 [-0.10, -0.01]
otel_to_otel_logs ingress throughput -0.10 [-0.58, +0.37]
process_agent_standard_check_with_stats memory utilization -0.19 [-0.23, -0.15]
tcp_syslog_to_blackhole ingress throughput -0.21 [-0.29, -0.13]
file_tree memory utilization -0.31 [-0.41, -0.22]
process_agent_real_time_mode memory utilization -0.37 [-0.40, -0.33]
idle memory utilization -0.38 [-0.42, -0.35]
file_to_blackhole % cpu utilization -1.60 [-7.34, +4.14]
basic_py_check % cpu utilization -1.83 [-4.26, +0.59]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@songy23 songy23 force-pushed the yang.song/otlp-trace-util branch from 628e542 to b95822f Compare April 2, 2024 13:58
pkg/trace/traceutil/otel_util.go Outdated Show resolved Hide resolved
pkg/trace/traceutil/otel_util.go Show resolved Hide resolved
@pducolin pducolin added qa/no-code-change No code change in Agent code requiring validation and removed qa/skip-qa labels Apr 3, 2024
Copy link
Contributor

@ahmed-mez ahmed-mez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any thoughts on adding @DataDog/opentelemetry as code owner of /pkg/trace/traceutil/otel*.go in https://github.com/DataDog/datadog-agent/blob/main/.github/CODEOWNERS ?

@songy23
Copy link
Member Author

songy23 commented Apr 3, 2024

Good point @ahmed-mez I updated the codeowners

Copy link
Member

@pgimalac pgimalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for ASC owned files

@songy23
Copy link
Member Author

songy23 commented Apr 3, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 3, 2024

🚂 MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 24m)

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 8822c5d into main Apr 3, 2024
187 of 188 checks passed
@dd-mergequeue dd-mergequeue bot deleted the yang.song/otlp-trace-util branch April 3, 2024 20:25
alexgallotta pushed a commit that referenced this pull request May 9, 2024
* [OTEL-1726] Add OTel span utils to tracetuil

* Address review comments

* Fix an import

* Update codeowners
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/opentelemetry OpenTelemetry team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants