Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move output dir logic to suite #29580
Move output dir logic to suite #29580
Changes from 9 commits
bdb2499
8492c11
dbc4f56
fa98745
13661b7
9cd6aaf
3b5e499
9e97f88
939587c
887fe43
03b852c
124d870
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💬 suggestion
What about passing the profile, and having the profile passing a path to the output root directory. Then each suite would create a directory inside the root directory, while the generic one is static.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I'm understanding.
profile.GetOutputDir()
already returns static output dir, e.g.~/e2e-output
. The suite callsGetRootOutputDir()
to create a new subdirectory for itself.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rename to
Create
fixes this tooThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I meant in my message is that is profile that knows where you are running. You might have a generic profile
GetLatestLink
that cleans up symlinks only onlocalprofile
and that does nothing on ci profile. You would call it here withrunner.GetProfile().CleanupOldLinks()
or a better name.