Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[system-probe] Add Oracle Linux to distros we install system-probe selinux policy on #29612

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

hmahmood
Copy link
Contributor

@hmahmood hmahmood commented Sep 26, 2024

What does this PR do?

Adds Oracle Linux to list of distros we install the system-probe selinux policy on.

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

@hmahmood hmahmood added component/system-probe qa/done Skip QA week as QA was done before merge and regressions are covered by tests labels Sep 26, 2024
@hmahmood hmahmood added this to the 7.59.0 milestone Sep 26, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Sep 26, 2024

[Fast Unit Tests Report]

On pipeline 45321147 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@hmahmood hmahmood force-pushed the hasan.mahmood/install-script-oracle-selinux branch from d2e69a0 to 4f8d1dc Compare September 26, 2024 20:49
@pr-commenter
Copy link

pr-commenter bot commented Sep 26, 2024

Regression Detector

Regression Detector Results

Run ID: cc080f12-4dbe-4115-ae17-326352f0b630 Metrics dashboard Target profiles

Baseline: 7fa44ed
Comparison: c46d768

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.01 [+0.27, +1.75] 1 Logs
file_tree memory utilization +0.47 [+0.38, +0.55] 1 Logs
basic_py_check % cpu utilization +0.45 [-2.20, +3.10] 1 Logs
idle memory utilization +0.30 [+0.26, +0.34] 1 Logs
idle_all_features memory utilization +0.04 [-0.04, +0.12] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.09, +0.08] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.11 [-0.16, -0.06] 1 Logs
pycheck_lots_of_tags % cpu utilization -0.41 [-2.90, +2.08] 1 Logs
otel_to_otel_logs ingress throughput -0.77 [-1.57, +0.03] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@hmahmood hmahmood marked this pull request as ready for review September 27, 2024 14:30
@hmahmood hmahmood requested review from a team as code owners September 27, 2024 14:30
@hmahmood hmahmood force-pushed the hasan.mahmood/install-script-oracle-selinux branch from 4f8d1dc to c46d768 Compare September 27, 2024 16:12
@hmahmood
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Sep 30, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 24m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit e31532d into main Sep 30, 2024
218 checks passed
@dd-mergequeue dd-mergequeue bot deleted the hasan.mahmood/install-script-oracle-selinux branch September 30, 2024 16:15
wdhif pushed a commit that referenced this pull request Oct 2, 2024
grantseltzer pushed a commit that referenced this pull request Oct 2, 2024
grantseltzer pushed a commit that referenced this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa/done Skip QA week as QA was done before merge and regressions are covered by tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants