-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CONTP-390] Allow user to set the cardinality of a check in the check configuration #29984
base: main
Are you sure you want to change the base?
Conversation
5be5dac
to
6715173
Compare
f7a7116
to
dc3045b
Compare
Regression DetectorRegression Detector ResultsRun ID: fade32d6-84c8-4eb0-be1a-bfb0cf50ddfb Metrics dashboard Target profiles Baseline: e0456b1 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.82 | [+0.10, +1.54] | 1 | Logs |
➖ | idle | memory utilization | +0.29 | [+0.24, +0.33] | 1 | Logs bounds checks dashboard |
➖ | idle_all_features | memory utilization | +0.08 | [-0.03, +0.18] | 1 | Logs bounds checks dashboard |
➖ | otel_to_otel_logs | ingress throughput | +0.03 | [-0.78, +0.84] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | +0.01 | [-0.24, +0.26] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | -0.00 | [-0.22, +0.22] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | -0.01 | [-0.35, +0.32] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.11, +0.09] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.05 | [-0.53, +0.43] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | -0.07 | [-0.26, +0.11] | 1 | Logs |
➖ | file_tree | memory utilization | -0.16 | [-0.28, -0.04] | 1 | Logs |
➖ | quality_gate_idle | memory utilization | -0.19 | [-0.24, -0.14] | 1 | Logs bounds checks dashboard |
➖ | quality_gate_idle_all_features | memory utilization | -0.57 | [-0.67, -0.47] | 1 | Logs bounds checks dashboard |
➖ | pycheck_lots_of_tags | % cpu utilization | -0.65 | [-3.09, +1.80] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.94 | [-0.99, -0.88] | 1 | Logs |
➖ | basic_py_check | % cpu utilization | -1.76 | [-4.40, +0.89] | 1 | Logs |
Bounds Checks
perf | experiment | bounds_check_name | replicates_passed |
---|---|---|---|
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 |
✅ | idle | memory_usage | 10/10 |
✅ | idle_all_features | memory_usage | 10/10 |
✅ | quality_gate_idle | memory_usage | 10/10 |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
1bbc6a6
to
1f5eb30
Compare
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=47046987 --os-family=ubuntu Note: This applies to commit c68540d |
1f5eb30
to
7ef6e07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm for AML
3c9aff2
to
c68540d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for comp/core/autodiscovery/listeners/cloudfoundry.go
What does this PR do?
Add check_tag_cardinality option in the check configuration. And if the user sets it, it overrides the value provided in the agent configuration.
See difference below
The cardinality is passed into this function in configresolver
Motivation
This will allow user to configure the cardinality of check instance (configured with a Pod annotation) directly inside the annotation check config.
Describe how to test/QA your changes
deploy dummy app
Compare config
"check_tag_cardinality": "low" vs
"check_tag_cardinality": "high",
Container name is high cardinality tag.
Also run
agent configcheck | grep redis -C 15
high
low
Possible Drawbacks / Trade-offs
Additional Notes