-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle DD_CONF_NODETREEMODEL
env var flag in UnmarshalKey
#30622
Conversation
14c164a
to
047a61c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion to fix, then LGTM
047a61c
to
6eca0c4
Compare
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=47953692 --os-family=ubuntu Note: This applies to commit 70a89f8 |
Regression DetectorRegression Detector ResultsRun ID: 378b5331-5aa5-4954-9265-4762e5fbf5ad Metrics dashboard Target profiles Baseline: 3c9edda Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | pycheck_lots_of_tags | % cpu utilization | +0.99 | [-1.59, +3.57] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.67 | [+0.19, +1.15] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | +0.56 | [+0.51, +0.61] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | +0.08 | [-0.17, +0.33] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | +0.01 | [-0.17, +0.20] | 1 | Logs |
➖ | otel_to_otel_logs | ingress throughput | +0.01 | [-0.80, +0.82] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.08, +0.10] | 1 | Logs |
➖ | basic_py_check | % cpu utilization | +0.00 | [-2.63, +2.64] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | -0.01 | [-0.23, +0.22] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | -0.01 | [-0.35, +0.33] | 1 | Logs |
➖ | idle_all_features | memory utilization | -0.24 | [-0.34, -0.14] | 1 | Logs bounds checks dashboard |
➖ | quality_gate_idle | memory utilization | -0.32 | [-0.37, -0.27] | 1 | Logs bounds checks dashboard |
➖ | idle | memory utilization | -0.50 | [-0.55, -0.45] | 1 | Logs bounds checks dashboard |
➖ | file_tree | memory utilization | -0.79 | [-0.92, -0.67] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | -0.87 | [-0.97, -0.77] | 1 | Logs bounds checks dashboard |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -1.36 | [-2.08, -0.64] | 1 | Logs |
Bounds Checks
perf | experiment | bounds_check_name | replicates_passed |
---|---|---|---|
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 |
✅ | idle | memory_usage | 10/10 |
✅ | idle_all_features | memory_usage | 10/10 |
✅ | quality_gate_idle | memory_usage | 10/10 |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
6eca0c4
to
70a89f8
Compare
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
Handle
DD_CONF_NODETREEMODEL
env var flag inUnmarshalKey
Describe how to test/QA your changes
Running the CI is enough as
DD_CONF_NODETREEMODEL
is not enable anywhere yet.