cmd/trace-agent: enable build for aix/ppc64 #6738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbbr
reviewed
Nov 12, 2020
knusbaum
force-pushed
the
knusbaum/aix-build
branch
3 times, most recently
from
d15da55 to
ea1514a
Compare
knusbaum
force-pushed
the
knusbaum/aix-build
branch
from
8ff8979 to
e040826
Compare
gbbr
approved these changes
Dec 3, 2020
Definitely. We will hopefully be able to automate the CI moving forward. Right now I'm running the unit tests and integration tests manually on an AIX machine. |
gbbr
force-pushed
the
knusbaum/aix-build
branch
2 times, most recently
from
bf8802e to
438340b
Compare
olivielpeau
reviewed
Mar 2, 2021
There was a problem hiding this comment.
LGTM, but the android build in gitlab is failing on this error, needs to be fixed:
# github.com/DataDog/datadog-agent/pkg/config
/go/src/github.com/DataDog/datadog-agent/pkg/config/config_android.go:35:14: cannot use afs (type AssetFs) as type afero.Fs in argument to config.SetFs:
AssetFs does not implement afero.Fs (missing Chown method)
Probably because type AssetFs in pkg/config/config_android.go needs to be updated to reflect the changes in the interface of afero.Fs introduced by the version update on github.com/spf13/afero
This commit adds support for building the trace-agent binary on AIX 7.2 for Power8 and Power9 architectures. The trace-agent binary is confirmed to run and successfully submit traces to the intake.
|
@olivielpeau I think we're good now. Can you PTAL? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for building the trace-agent binary on AIX 7.2 for
Power8 and Power9 architectures. The trace-agent binary is confirmed to run
and successfully submit traces to the intake.
This PR depends on a PR to our viper fork (DataDog/viper#15). As such, his PR requires a version bump to
github.com/DataDog/viperonce that PR is merged and a new version is tagged.