Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update snyk #6965

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Update snyk #6965

merged 1 commit into from
Dec 11, 2020

Conversation

albertvaka
Copy link
Contributor

@albertvaka albertvaka commented Dec 11, 2020 •
edited
Loading

Motivation

Seems to fix the security_scan job crashing with an OOM error.

@albertvaka albertvaka added changelog/no-changelog [deprecated] team/agent-platform [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card labels Dec 11, 2020
@albertvaka albertvaka added this to the 7.25.0 milestone Dec 11, 2020
@albertvaka albertvaka requested a review from a team as a code owner December 11, 2020 12:35
mx-psi
mx-psi approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should we merge the PR updating the image first?

@albertvaka
Copy link
Contributor Author

albertvaka commented Dec 11, 2020 •
edited
Loading

I think we can leave it like this. I like pining a version better than using latest.

@albertvaka albertvaka merged commit 595446d into master Dec 11, 2020
@albertvaka albertvaka deleted the albertvaka/fix-snyk branch December 11, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card [deprecated] team/agent-platform
Projects
None yet
Milestone
7.25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@albertvaka @mx-psi