pkg/{trace, config}: add support for statsd over windows pipes #7186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the dogstatsd_windows_pipe_name and the corresponding env variable DD_DOGSTATSD_WINDOWS_PIPE_NAME to pkg/config. It also adds support for these in pkg/trace/config and pkg/trace/metrics. When dogstatsd_windows_pipe_name is defined, the trace agent will use the specified pipe for dogstatsd communication with the agent core.
|
Need to add unit test and release note. @colin-higgins please have a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the dogstatsd_windows_pipe_name and the corresponding env
variable DD_DOGSTATSD_WINDOWS_PIPE_NAME to pkg/config. It also adds support
for these in pkg/trace/config and pkg/trace/metrics.
When dogstatsd_windows_pipe_name is defined, the trace agent will use the
specified pipe for dogstatsd communication with the agent core.
Motivation
This is a follow-on from #6615. When the agent is running on windows pipes, currently no internal metrics are communicated to the agent core.
Describe your test plan
Write there any instructions and details that should be tested during the QA.
This should be manually tested on a Windows machine, ensuring that trace agent metrics are appearing in the UI when DD_DOGSTATSD_WINDOWS_PIPE_NAME and/or dogstatsd_windows_pipe_name are set.