Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking Change in v2-1.16.0 #294

Closed
automartin5000 opened this issue Sep 9, 2024 · 5 comments
Closed

Breaking Change in v2-1.16.0 #294

automartin5000 opened this issue Sep 9, 2024 · 5 comments
Assignees

Comments

@automartin5000
Copy link

It looks like y'all just released a major breaking change in v2-1.16.0 to the Datadog API interface by renaming DatadogProps to DatadogLambdaProps. It seems like that should be reverted or the major version bumped.

@pwrmiller
Copy link

Confirmed here. In Python, you'll see an error message similar to:

ImportError: cannot import name 'DatadogProps' from 'datadog_cdk_constructs_v2'

I've added the error message here to assist with visibility, and agree that this represents a major version/ breaking change.

@lym953 lym953 self-assigned this Sep 9, 2024
@lym953
Copy link
Contributor

lym953 commented Sep 9, 2024

Looking.

@lym953
Copy link
Contributor

lym953 commented Sep 9, 2024

Thanks for reporting. It should have been fixed in v1.16.1. Could you retry?

@JuliaLid
Copy link

JuliaLid commented Sep 9, 2024

I can confirm that updating to v1.16.1 fixed the issue that @pwrmiller reported earlier.

@automartin5000
Copy link
Author

Confirmed working from our side. Thanks for the quick revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants