fix: revert "chore: rename Lambda related interfaces (#288)" #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| constructor(scope: Construct, id: string, props: DatadogLambdaProps) { | ||
| if (process.env.DD_CONSTRUCT_DEBUG_LOGS?.toLowerCase() === "true") { | ||
| constructor(scope: Construct, id: string, props: DatadogProps) { | ||
| if (process.env.DD_CONSTRUCT_DEBUG_LOGS?.toLowerCase() == "true") { |
There was a problem hiding this comment.
⚪ Code Quality Violation
Suggested change
| if (process.env.DD_CONSTRUCT_DEBUG_LOGS?.toLowerCase() == "true") { | |
| if (process.env.DD_CONSTRUCT_DEBUG_LOGS?.toLowerCase() === "true") { |
Expected '===' and instead saw '=='. (...read more)
In JavaScript, == and != comparisons do type coercion, which can be confusing and may introduce potential errors. Use the type-safe equality operators === and !== instead.
| constructor(scope: Construct, id: string, props: DatadogLambdaProps) { | ||
| if (process.env.DD_CONSTRUCT_DEBUG_LOGS?.toLowerCase() === "true") { | ||
| constructor(scope: Construct, id: string, props: DatadogProps) { | ||
| if (process.env.DD_CONSTRUCT_DEBUG_LOGS?.toLowerCase() == "true") { |
There was a problem hiding this comment.
⚪ Code Quality Violation
Suggested change
| if (process.env.DD_CONSTRUCT_DEBUG_LOGS?.toLowerCase() == "true") { | |
| if (process.env.DD_CONSTRUCT_DEBUG_LOGS?.toLowerCase() === "true") { |
Expected '===' and instead saw '=='. (...read more)
In JavaScript, == and != comparisons do type coercion, which can be confusing and may introduce potential errors. Use the type-safe equality operators === and !== instead.
purple4reina
approved these changes
Sep 9, 2024
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reverts #288
Motivation
#294
Testing Guidelines
for Python
Steps
DatadogProps480eed0Result
Before:
cdk deploygives an error:After:
cdk deployruns successfullyfor Go
Similar. Reproduced the issue on v1.16.0, and ensure the issue is fixed by the PR.
Additional Notes
Types of Changes
Check all that apply