Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix README.md: enableSourceCodeIntegration is wrong #241

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Dec 18, 2023

What does this PR do?

Change enableSourceCodeIntegration to sourceCodeIntegration in README

Motivation

TypeScript compiler claims that there is no enableSourceCodeIntegration property.

readonly sourceCodeIntegration?: boolean;

Testing Guidelines

N/A

Additional Notes

N/A

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@exoego exoego requested a review from a team as a code owner December 18, 2023 03:18
@exoego exoego changed the title Update README.md Update README.md: enableSourceCodeIntegration is wrong Dec 18, 2023
@exoego exoego changed the title Update README.md: enableSourceCodeIntegration is wrong Fix README.md: enableSourceCodeIntegration is wrong Dec 18, 2023
Copy link

@jhgilbert jhgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No review needed from Documentation on this change.

Copy link
Contributor

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🙇🏽

@TalUsvyatsky TalUsvyatsky changed the title Fix README.md: enableSourceCodeIntegration is wrong docs: Fix README.md: enableSourceCodeIntegration is wrong Sep 16, 2024
@TalUsvyatsky TalUsvyatsky changed the title docs: Fix README.md: enableSourceCodeIntegration is wrong fix: Fix README.md: enableSourceCodeIntegration is wrong Sep 16, 2024
@TalUsvyatsky TalUsvyatsky merged commit c82ff89 into DataDog:main Sep 16, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants