Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure ASM does not apply when the extension is not present #258

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

astuyve
Copy link
Contributor

@astuyve astuyve commented Apr 2, 2024

What does this PR do?

We identified and fixed a similar issue in the serverless plugin where ASM config may inadvertently be applied to functions without the extension configured.
This would cause those functions to crash.

Motivation

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@astuyve astuyve requested a review from a team as a code owner April 2, 2024 11:19
@astuyve astuyve merged commit 6cef564 into main Apr 17, 2024
12 checks passed
@astuyve astuyve deleted the aj/check-extension-before-asm branch April 17, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants