-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support Go #267
feat: Support Go #267
Conversation
8a9bd32
to
39be4b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome, thanks!! Let's make sure that publishing to npm is unaffected but I think the script should be fine, tsc
SHOULD blow away the dist
directory and then re-build.
Sweet!
39be4b5
to
7efd263
Compare
Renamed the Go package from
|
7efd263
to
e3a1fa8
Compare
e3a1fa8
to
a10c530
Compare
Talked with @astuyve and renamed the package as |
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
Support Golang.
Some details:
v2-1.14.0
to make this commit found easily when we later send it to Go package library/dist/go
, where the Go package is outputted, so the Go package code can be tracked by Git and uploaded. Currently the entire/dist
folder is ignored./dist/go
to.gitattributes
so that these generated files will be collapsed on GitHub, to avoid making code review difficult.Motivation
From Feature Request: Datadog CDK Construct for Go
Testing Guidelines
I don't know a way to test it at this stage.
My planned next steps are:
README.md
Please let me know if there's a good way to test it at this state, or there are other next steps I should take.
Additional Notes
Types of Changes
Check all that apply