Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Go icon and fix a command in README #278

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

lym953
Copy link
Contributor

@lym953 lym953 commented Aug 13, 2024

What does this PR do?

In README.md:

  1. Add a Go icon which links to the package page on pkg.go.dev
  2. fix the Go installation command

Motivation

Testing Guidelines

  1. Check the rendered icon in README. It looks good. image

    • Click on it. It redirects to the right page.
  2. Run the Go installation command. No error.

yiming.luo@COMP-J7WRL6274T go-stack % go get github.com/DataDog/datadog-cdk-constructs-go/ddcdkconstruct
go: downloading github.com/DataDog/datadog-cdk-constructs-go/ddcdkconstruct v1.14.0
go: downloading github.com/DataDog/datadog-cdk-constructs-go v0.0.0-20240813202855-e43af4f7c380
go: upgraded github.com/DataDog/datadog-cdk-constructs-go/ddcdkconstruct v1.13.0 => v1.14.0
yiming.luo@COMP-J7WRL6274T go-stack % 

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@lym953 lym953 requested a review from a team as a code owner August 13, 2024 22:37
@lym953
Copy link
Contributor Author

lym953 commented Aug 14, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Aug 14, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 4m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit dca371b into main Aug 14, 2024
14 checks passed
@dd-mergequeue dd-mergequeue bot deleted the yiming.luo/support-golang branch August 14, 2024 17:55
@lym953 lym953 linked an issue Aug 20, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go support
2 participants