chore: move setTags() to a separate file #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| import * as lambda from "aws-cdk-lib/aws-lambda"; | ||
| import { DatadogLambda } from "../src/index"; | ||
|
|
||
| const versionJson = require("../version.json"); |
There was a problem hiding this comment.
🟠 Code Quality Violation
Require statement not part of import statement. (...read more)
Use ESM instead of CommonJS imports.
lym953
changed the title
purple4reina
approved these changes
Nov 7, 2024
|
/merge |
Devflow running:
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Right now
datadog-lambda.tshas a functionsetTags(), which setsenv,service,versionand custom tags passed viaDatadogLambdaProps.What does this PR do?
Moves this function and its associated tests to separate files
tag.tsandtag.spec.ts, so they can be reused by Step Function code.Motivation
Testing Guidelines
Existing tests still pass.
Additional Notes
Next step:
Need a stamp from Cloud Tracing team, who, as the downstream consumer, should know what tags should be set here.
Types of Changes
Check all that apply