feat: Set dd_cdk_construct version tag on state machine #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| @@ -12,6 +12,8 @@ import * as sfn from "aws-cdk-lib/aws-stepfunctions"; | |||
| import log from "loglevel"; | |||
| import { TagKeys, DatadogLambdaProps, DatadogStepFunctionsProps } from "./index"; | |||
|
|
|||
| const versionJson = require("../version.json"); | |||
There was a problem hiding this comment.
🟠 Code Quality Violation
Require statement not part of import statement. (...read more)
Use ESM instead of CommonJS imports.
lym953
force-pushed
the
yiming.luo/step-function-support-8
branch
3 times, most recently
from
6e22a20 to
e190c49
Compare
lym953
force-pushed
the
yiming.luo/step-function-support-9
branch
from
a5dca55 to
df9fb18
Compare
|
/merge |
Devflow running:
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When instrumenting a state machine, set a tag like
dd_cdk_construct:1.19.0, similar to the practice for Lambda in CDK and for Step Functions in CI (dd_sls_citag) and Serverless Plugin (dd_sls_plugintag).Motivation
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply