Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use framework name as test module name to make test fingerprints stable #131

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

anmarchenko
Copy link
Member

@anmarchenko anmarchenko commented Mar 6, 2024

What does this PR do?

Fixes customer-reported issue with flaky test detection after test suite level visibility release.

Bug description

Currently test_module_end events have the same name as test_session_end which could be different between test runs: we use test command value this and test command could include variable data (like --seed param). The problem is that test module name is part of test fingerprint, and unstable fingerprints make flaky test detection impossible.

How is it fixed?

We change test module name to be just the test framework name (minitest, rspec, or cucumber). NOTE: This change will cause fingerprint updates for all current tests.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.08%. Comparing base (e016c07) to head (0af6423).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #131   +/-   ##
=======================================
  Coverage   99.08%   99.08%           
=======================================
  Files         156      156           
  Lines        7102     7102           
  Branches      303      300    -3     
=======================================
  Hits         7037     7037           
  Misses         65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anmarchenko anmarchenko marked this pull request as ready for review March 7, 2024 11:28
@anmarchenko anmarchenko requested review from a team as code owners March 7, 2024 11:28
@anmarchenko anmarchenko merged commit 0cb187c into main Mar 7, 2024
26 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/fix_test_module_names branch March 7, 2024 14:12
@github-actions github-actions bot added this to the 1.0.0 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants