-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIVIS-2938] Git tree upload - git command line integration #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 1.0 #151 +/- ##
==========================================
+ Coverage 99.02% 99.03% +0.01%
==========================================
Files 179 182 +3
Lines 8090 8229 +139
Branches 339 341 +2
==========================================
+ Hits 8011 8150 +139
Misses 79 79 ☔ View full report in Codecov by Sentry. |
juan-fernandez
approved these changes
Apr 5, 2024
…ing logger directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Datadog::CI::Git::LocalRepository
exec_git_command
inaccessible from outside of this module to make shell injections less likely by reviewing that all calls to this method are done with static parametersgit_commits
,git_commits_rev_list
,git_generate_packfiles
methods to support git tree uploading functionalityHow to test the change?
Unit tests are provided