Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIVIS-2863] Git repository unshallowing logic #155

Merged
merged 9 commits into from
Apr 10, 2024

Conversation

anmarchenko
Copy link
Member

@anmarchenko anmarchenko commented Apr 9, 2024

What does this PR do?
Adds the following git unshallowing logic to this library:

image

Also implements unshallowing optimization: if all commits from the shallow repo are present in the backend, we skip the git upload alltogether.

How to test the change?
Unit tests are provided

@anmarchenko anmarchenko changed the title Git repository unshallowing logic [CIVIS-2863] Git repository unshallowing logic Apr 9, 2024
@anmarchenko anmarchenko changed the base branch from anmarchenko/git_tree_uploader to 1.0 April 9, 2024 11:25
@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 99.00%. Comparing base (86d6c60) to head (2bcb5f0).

Files Patch % Lines
lib/datadog/ci/git/local_repository.rb 55.55% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              1.0     #155      +/-   ##
==========================================
- Coverage   99.04%   99.00%   -0.04%     
==========================================
  Files         190      190              
  Lines        8595     8665      +70     
  Branches      369      371       +2     
==========================================
+ Hits         8513     8579      +66     
- Misses         82       86       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anmarchenko anmarchenko changed the base branch from 1.0 to anmarchenko/git_tree_uploader April 9, 2024 13:06
@anmarchenko anmarchenko marked this pull request as ready for review April 9, 2024 13:14
@anmarchenko anmarchenko requested review from a team as code owners April 9, 2024 13:14
@anmarchenko anmarchenko requested a review from tonyredondo April 9, 2024 13:14
Base automatically changed from anmarchenko/git_tree_uploader to 1.0 April 9, 2024 16:34
@anmarchenko anmarchenko force-pushed the anmarchenko/git_unshallowing branch from d4dc648 to 97bcfac Compare April 10, 2024 08:01
@anmarchenko anmarchenko merged commit 39f3f3c into 1.0 Apr 10, 2024
23 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/git_unshallowing branch April 10, 2024 08:40
@anmarchenko anmarchenko added this to the 1.0 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants