[CIVIS-2934] ITR test skipping implementation #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 1.0 #160 +/- ##
==========================================
- Coverage 99.05% 98.90% -0.16%
==========================================
Files 195 196 +1
Lines 9032 9326 +294
Branches 390 404 +14
==========================================
+ Hits 8947 9224 +277
- Misses 85 102 +17 ☔ View full report in Codecov by Sentry. |
…e for unskippable tests
…ount for unskippable tests
juan-fernandez
approved these changes
Apr 22, 2024
marcotc
reviewed
Apr 22, 2024
| def execute(*args) | ||
| test_span = CI.active_test | ||
| if test_span&.skipped_by_itr? | ||
| @action.skip(*args) |
There was a problem hiding this comment.
I'm guessing Cucumber doesn't have a way to report the message CI::Ext::Test::ITR_TEST_SKIP_REASON, unlike Minitest and RSpec?
There was a problem hiding this comment.
Yep, at least not easily findable.
skip_this_scenario method does not accept arguments with skip reason for example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
How to test the change?
Tested on DD staging.
Results for Rubocop:
Results for sidekiq:
