Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIVIS-9014] implement "why this test was skipped" feature by adding ITR correlation to test events #165

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

anmarchenko
Copy link
Member

@anmarchenko anmarchenko commented Apr 24, 2024

What does this PR do?
To show "why this test was skipped" explanation in the Datadog UI, we need to send itr_correlation_id field in content part of test events: this PR adds just that.

TestVisibility::Transport obtains itr_correlation_id by calling a method on ITR::Runner directly and then passes to serializers via new options keyword parameter.

How to test the change?
Tested using anmarchenko/jekyll project on dd-staging with the following result:
image

@anmarchenko anmarchenko changed the title Anmarchenko/itr_correlation_id [CIVIS-9014] implement "why this test was skipped" feature by adding ITR correlation to test events Apr 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.06%. Comparing base (d0cfdc9) to head (f8d1a7c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #165   +/-   ##
=======================================
  Coverage   99.05%   99.06%           
=======================================
  Files         196      196           
  Lines        9340     9377   +37     
  Branches      404      407    +3     
=======================================
+ Hits         9252     9289   +37     
  Misses         88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anmarchenko anmarchenko marked this pull request as ready for review April 24, 2024 10:53
@anmarchenko anmarchenko requested review from a team as code owners April 24, 2024 10:53
@anmarchenko anmarchenko requested a review from tonyredondo April 24, 2024 10:53
@anmarchenko anmarchenko merged commit f0592d1 into main Apr 24, 2024
26 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/itr_correlation_id branch April 24, 2024 12:08
@github-actions github-actions bot added this to the 1.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants