Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO TICKET] more debug logging, do not skip tests when running in forked processes #168

Merged
merged 4 commits into from
Apr 29, 2024

Conversation

anmarchenko
Copy link
Member

@anmarchenko anmarchenko commented Apr 29, 2024

What does this PR do?
A couple of smaller changes ahead of ITR public beta:

  • more debug logging
  • error handling for coverage writer: instead of silently killing the the coverage writer on errors print WARN messages and back-off
  • do not skip tests when using forked test runners (to be supported later)
  • disable startup logging from tracing as it is useless for test visibility mode and spams logs

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 98.98%. Comparing base (4534437) to head (2bea9f7).

Files Patch % Lines
lib/datadog/ci/itr/coverage/writer.rb 0.00% 5 Missing ⚠️
lib/datadog/ci/itr/runner.rb 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
- Coverage   99.04%   98.98%   -0.07%     
==========================================
  Files         198      198              
  Lines        9627     9638      +11     
  Branches      421      423       +2     
==========================================
+ Hits         9535     9540       +5     
- Misses         92       98       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anmarchenko anmarchenko marked this pull request as ready for review April 29, 2024 10:58
@anmarchenko anmarchenko requested review from a team as code owners April 29, 2024 10:58
@anmarchenko anmarchenko changed the title more debug logging, do not skip tests when running in forked processes [NO TICKET] more debug logging, do not skip tests when running in forked processes Apr 29, 2024
@anmarchenko anmarchenko merged commit 042bb0f into main Apr 29, 2024
26 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/debug_skippable_tests branch April 29, 2024 14:01
@github-actions github-actions bot added this to the 1.0 milestone Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants