[NO-TICKET] automatically trace with correct time even when time is stubbed by timecop #185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
timecop is a popular gem that is used to mock time in tests. It works by replacing Time.now method and aliasing the original as
now_without_mock_time
.This creates issues with tests tracing as reported spans has invalid time and thus are being skipped or reported with wrong timestamps.
It is possible to setup time_now_provider in settings: we can do this automatically when activating CI mode so that no manual work from user's side is needed.
Motivation
We received multiple customer support issues related to invalid start_time.
How to test the change?
Unit tests are provided (with timecop dependency).